Review Request: Fix the minimum size of some applets

Maarten De Meyer de.meyer.maarten at gmail.com
Fri Jun 22 06:17:41 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105234/
-----------------------------------------------------------

(Updated June 22, 2012, 6:17 a.m.)


Review request for Plasma.


Changes
-------

Now it does not break in panels. Is setMinimumSize(-1, -1) correct for panels?
Pastebin and  showDashboar break if panel < 16 pixels and weatherstation has a visual glitch when it is minimised on the desktop after being placed in a panel.


Description
-------

This fixes the minimum size of the following applets: showdashboard, systemloadviewer, pastebin, weatherstation and timer.
Some sizes were to small, so there were visual glitches and some applets had no minimum value set.

I have no commit rights.


Diffs (updated)
-----

  applets/pastebin/pastebin.cpp 208e6a3 
  applets/showdashboard/showdashboard.h 695347f 
  applets/showdashboard/showdashboard.cpp 1c2f623 
  applets/systemloadviewer/systemloadviewer.cpp b852256 
  applets/timer/timer.cpp ba5ee66 
  applets/weatherstation/weatherstation.h 6d4ae24 
  applets/weatherstation/weatherstation.cpp 8ada9c2 

Diff: http://git.reviewboard.kde.org/r/105234/diff/


Testing
-------

Run the applets with their new minimum size, and minimized.


Thanks,

Maarten De Meyer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120622/49ea1d44/attachment-0001.html>


More information about the Plasma-devel mailing list