Review Request: Use common plasma components Tooltip in battery monitor

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105283/#review14820
-----------------------------------------------------------

Ship it!


Ship It!

- Aaron J. Seigo


On June 17, 2012, 7:52 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105283/
> -----------------------------------------------------------
> 
> (Updated June 17, 2012, 7:52 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Current battery monitor implements it's own Button class, this previously broke styles with theme text and overloads icon sizes and such.
> 
> It's bad for applets to implement their own version of common classes as it prevents consistency.
> 
> (will fix the whitespace addition before commit)
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml d4454c6 
>   plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml a2ab72a 
> 
> Diff: http://git.reviewboard.kde.org/r/105283/diff/
> 
> 
> Testing
> -------
> 
> Checked applet looked ok.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120618/84d170a9/attachment.html>