Review Request: Use common plasma components Tooltip in battery monitor

David Edmundson kde at davidedmundson.co.uk
Sun Jun 17 19:52:09 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105283/
-----------------------------------------------------------

Review request for Plasma.


Description
-------

Current battery monitor implements it's own Button class, this previously broke styles with theme text and overloads icon sizes and such.

It's bad for applets to implement their own version of common classes as it prevents consistency.

(will fix the whitespace addition before commit)


Diffs
-----

  plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml d4454c6 
  plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml a2ab72a 

Diff: http://git.reviewboard.kde.org/r/105283/diff/


Testing
-------

Checked applet looked ok.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120617/cdde3c45/attachment.html>


More information about the Plasma-devel mailing list