Review Request: Icontasks: Add (hidden) config-option to manually set media-applications

Anton Kreuzkamp akreuzkamp at web.de
Sat Jun 2 19:57:28 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105137/
-----------------------------------------------------------

Review request for Plasma and Craig Drummond.


Description
-------

This patch adds a option to the config-file to manually set media apps, for applications that provide an mpris interface, but don't belong into the categories AudioVideo or Music, like rekonq (with this patch: https://git.reviewboard.kde.org/r/105059/). Rekonq is also added to the default-config.

This patch actually contains 3 commits: 1. Fix a bug that made the mediabuttons.cpp never be read (due to a wrong filepath) 2. Add the config-option 3. Add rekonq to the customMediaApps in the default config.

I guess it cannot be seen as a bugfix (didn't correctly find all media-applications) and so has to wait for 4.10, right?


Diffs
-----

  applets/icontasks/mediabuttons.h 00fbfd8 
  applets/icontasks/mediabuttons.cpp dff97fb 
  applets/icontasks/mediabuttonsrc 37e7d91 

Diff: http://git.reviewboard.kde.org/r/105137/diff/


Testing
-------

Tested with rekonq, works like a charm. No problems I could think of.


Thanks,

Anton Kreuzkamp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120602/fc326459/attachment.html>


More information about the Plasma-devel mailing list