<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105137/">http://git.reviewboard.kde.org/r/105137/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Craig Drummond.</div>
<div>By Anton Kreuzkamp.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds a option to the config-file to manually set media apps, for applications that provide an mpris interface, but don't belong into the categories AudioVideo or Music, like rekonq (with this patch: https://git.reviewboard.kde.org/r/105059/). Rekonq is also added to the default-config.
This patch actually contains 3 commits: 1. Fix a bug that made the mediabuttons.cpp never be read (due to a wrong filepath) 2. Add the config-option 3. Add rekonq to the customMediaApps in the default config.
I guess it cannot be seen as a bugfix (didn't correctly find all media-applications) and so has to wait for 4.10, right?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with rekonq, works like a charm. No problems I could think of.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/icontasks/mediabuttons.h <span style="color: grey">(00fbfd8)</span></li>
<li>applets/icontasks/mediabuttons.cpp <span style="color: grey">(dff97fb)</span></li>
<li>applets/icontasks/mediabuttonsrc <span style="color: grey">(37e7d91)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105137/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>