Review Request: add keyboard nav to konsoleprofiles widget

Greg T yellowcake- at gmx.net
Sat Jul 28 16:34:35 UTC 2012



> On July 28, 2012, 4:06 p.m., Shaun Reich wrote:
> > Ship It!
> 
> Shaun Reich wrote:
>     Looks good. Think you could also propagate this to the Kate and Konsole widgets?

I can also add this to konqprofiles. I don't know what konsole widgets you are referring to.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105765/#review16571
-----------------------------------------------------------


On July 28, 2012, 11:24 a.m., Greg T wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105765/
> -----------------------------------------------------------
> 
> (Updated July 28, 2012, 11:24 a.m.)
> 
> 
> Review request for Plasma and Shaun Reich.
> 
> 
> Description
> -------
> 
> adds keyboard navigation. up/down arrow key to select item, Enter to open it
> 
> 
> This addresses bug 303297.
>     http://bugs.kde.org/show_bug.cgi?id=303297
> 
> 
> Diffs
> -----
> 
>   applets/konsoleprofiles/package/contents/ui/konsoleprofiles.qml c4c76927208a40c586a93e60a7c1b71ffc4e23b8 
> 
> Diff: http://git.reviewboard.kde.org/r/105765/diff/
> 
> 
> Testing
> -------
> 
> tested in a panel
> 
> 
> Thanks,
> 
> Greg T
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120728/b17ba6dc/attachment-0001.html>


More information about the Plasma-devel mailing list