Review Request: Make sure kmenuedit use predictable order for showing "Name" and "Description" between various invocations
Jekyll Wu
adaptee at gmail.com
Sat Jul 28 13:11:55 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105769/
-----------------------------------------------------------
Review request for Plasma.
Description
-------
The cause is simple: two flags m_detailedMenuEntries and m_detailedEntriesNamesFirst are never explicitly initialized. So their values are random, and the final results are unpredictable.
The patch simply initializes both as true, since that seems to be the default behavior of kickoff.
The git history shows those two flags seem to be something left over from the KDE3 era. Maybe they should just be removed from the code. However, I'm not familiar with the code and the history, so this simple patch should be safe choice.
This addresses bug 304177.
http://bugs.kde.org/show_bug.cgi?id=304177
Diffs
-----
kmenuedit/treeview.cpp 54feff7
Diff: http://git.reviewboard.kde.org/r/105769/diff/
Testing
-------
Thanks,
Jekyll Wu
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120728/af2eaae4/attachment.html>
More information about the Plasma-devel
mailing list