Review Request: Improve the QML RunnerModel

Aleix Pol Gonzalez aleixpol at gmail.com
Sat Feb 11 11:41:37 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103806/
-----------------------------------------------------------

(Updated Feb. 11, 2012, 11:41 a.m.)


Review request for Plasma.


Changes
-------

Hey Aaron! You were right, those two last methods I added them because I wanted to make the plugin configure stuff but I ended up doing it in a different way, actually using the KPluginSelector which will have to be implemented in QtQuick eventually.

I removed all the QObject expositions I had, I hope you're all happy now ;).


Description
-------

Adds some features to the RunnerModel so that it can be used properly in the KRunner QML implementation I've been working on (see the testing section).

Also it simplifies the code a bit by moving from QAbstractItemModel -> QAbstractListModel.


Diffs (updated)
-----

  components/runnermodel/runnermodel.h 899bf1f 
  components/runnermodel/runnermodel.cpp a226f8e 

Diff: http://git.reviewboard.kde.org/r/103806/diff/diff


Testing
-------

use it in kde:scratch/apol/krunner-qml (proof of concept for a KRunner implemented in QtQuick).

here's a video, so that you know what's going on: http://www.proli.net/meu/netrunner/qmlrunner.ogv


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120211/1666e0fc/attachment-0001.html>


More information about the Plasma-devel mailing list