Review Request: Improve the QML RunnerModel

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103806/#review10471
-----------------------------------------------------------



components/runnermodel/runnermodel.cpp
<http://git.reviewboard.kde.org/r/103806/#comment8572>

    the Enabled role is missing now



components/runnermodel/runnermodel.cpp
<http://git.reviewboard.kde.org/r/103806/#comment8573>

    what is access to the Runner pointer needed for? i'm very hesitant to expose those pointers.



components/runnermodel/runnermodel.cpp
<http://git.reviewboard.kde.org/r/103806/#comment8575>

    what are the use cases for these methods? i'm undecided whether i agree with them being here, but that really depends on what you plan on using them for :)


- Aaron J. Seigo


On Feb. 7, 2012, 11:23 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103806/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2012, 11:23 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Adds some features to the RunnerModel so that it can be used properly in the KRunner QML implementation I've been working on (see the testing section).
> 
> Also it simplifies the code a bit by moving from QAbstractItemModel -> QAbstractListModel.
> 
> 
> Diffs
> -----
> 
>   components/runnermodel/runnermodel.h 899bf1f 
>   components/runnermodel/runnermodel.cpp a226f8e 
> 
> Diff: http://git.reviewboard.kde.org/r/103806/diff/diff
> 
> 
> Testing
> -------
> 
> use it in kde:scratch/apol/krunner-qml (proof of concept for a KRunner implemented in QtQuick).
> 
> here's a video, so that you know what's going on: http://www.proli.net/meu/netrunner/qmlrunner.ogv
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120210/4c8d2d2a/attachment-0001.html>