Review Request: Fix collapsed folderview in panels

Ignat Semenov 13thguards at gmail.com
Fri Feb 10 19:16:49 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103915/
-----------------------------------------------------------

Review request for Plasma and Aaron J. Seigo.


Description
-------

Fix folderview behavior in panels with regard to the collapsed mode.

1)Keep it small like Trash or Show desktop / Dashboard (ConstrainedSquare, minimumSize & sizeHint - code taken from Trash, which behaves properly when in a panel with regard to scaling).
2)Update icon size on panel icon size change.
3)No duplicates - if (m_iconWidget) check - the absence of such a  check resulted in Really Weird(TM) things going on, like duplicates or ghost folderviews.


This addresses bug 244557.
    http://bugs.kde.org/show_bug.cgi?id=244557


Diffs
-----

  plasma/applets/folderview/folderview.cpp c3b6e2a 

Diff: http://git.reviewboard.kde.org/r/103915/diff/diff


Testing
-------

Tested the hell out of it:dragged the panel around the screen on all the 4 screen edges - no problems noticed. Changed Panel icon size in the Icons KCM, updates on the fly.


Thanks,

Ignat Semenov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120210/31a92d86/attachment.html>


More information about the Plasma-devel mailing list