Review Request: Allow to choose between ascending and descending icon sort order in folderview

Aaron J. Seigo aseigo at kde.org
Fri Feb 10 07:56:53 UTC 2012


On Monday, February 6, 2012 14:44:25 Ignat Semenov wrote:
> Marco Martin wrote:
> > On Mon, Feb 6, 2012 at 9:22 AM, Ignat Semenov <ragnarokk91 at gmail.com>
> > 
> > wrote:
> >> Hello fellow plasma devs!
> >> 
> >> This change, while trivial, contains 2 strings, "Ascending" and
> >> "Desending". I've found out that the very same strings already exist in
> >> Dolphin, which lives in the same module as plasma-applet-folderview, kde-
> >> baseapps. Does that mean that this commit can be backported to 4.8?
> > 
> > well, regardless of the strings, that's a feature, so i would prefer it
> > 4.9 only
> 
> Hello Marco,
> 
> In the case that I won't backport the change, will I be able to backport
> later commits using git cherry-pick correctly? Does Git use the diffs for
> cherry-picking?

it uses the diff of the current change; it doesn't need to replay all changes 
in between. of course, if a change touches code that this commit changes, then 
that change will need to be manually merged back. but generally git makes this 
as easy as it can be.

> Another one is, of course, that this useful feature will have a
> longer lifetime and more users :)

we could say that about every feature :)

-- 
Aaron J. Seigo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120210/2ec48cbf/attachment.sig>


More information about the Plasma-devel mailing list