Review Request: Expose default Plasma theme to QML based KSplash

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105761/
-----------------------------------------------------------

(Updated Dec. 19, 2012, 6:30 p.m.)


Review request for Plasma and Ivan Čukić.


Changes
-------

I found an old review to ksplash posted 4 months ago, but the groups wasn't set, so I imagine no-one here saw it.

I've abused my reviewboard super powers to add it.
Nuno Bento also wrote a clone of the existing KSplash air theme in QML which uses this patch. I guess it never got anywhere. I have a copy of it. If Nuno doesn't reply to my emails, I'll post it to RB myself.


Description
-------

This patch modifies KSplashQML allowing it to exposes the default Plasma theme to QML splash screens. 
The idea was taken from the work done by David Edmundson and Aurélien Gâteau in LightDM-KDE.

Giving QML splash themes access to the default Plasma theme makes it possible to create themes that transition seamlessly to the desktop (for anyone using the default wallpaper). It also makes it possible to recreate the default KSplash theme in QML with 2 major benefits over the existing one: 1) the wallpaper image used is appropriate to the user's resolution and 2) the theme doesn't need to be modified between releases since it always uses the wallpaper from the default Plasma theme.

I've already implemented and tested a recreation of the Default theme in QML and will post the patch if this one gets accepted.


Diffs
-----

  ksplash/ksplashqml/CMakeLists.txt c2065d9 
  ksplash/ksplashqml/SplashWindow.cpp 4417643 

Diff: http://git.reviewboard.kde.org/r/105761/diff/


Testing
-------

1. Applied path to new kde:kde-workspace clone
2. Compiled and installed ksplashqml
3. Modified Minimalistic theme to use Image as background with source set to plasmaTheme.wallpaperPath(screenSize)
4. Created another QML based theme similar to the Default one
5. Tested login with 2 different users using both themes


Thanks,

Nuno Bento

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121219/d4aee2ce/attachment.html>