Review Request: KSNI: fix IconThemePath support

[Harald Sitter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107702/
-----------------------------------------------------------

(Updated Dec. 17, 2012, 12:42 p.m.)


Review request for Plasma.


Changes
-------

instead of exposing iconthemepath and expecting iconitem to handle it, introduce a new customIcon invokable on the task and call that from qml.
customicon expects a variant and if it is a string it will do a full custom icon resolution iff no SVG override can be found and a custom icon loader is present (iconthemepath of acceptable format)


Description (updated)
-------

KSNI: fix IconThemePath support

IconThemePath is used by a Canonical Patch to enable all Qt apps using
QSystemTrayIcon to transparently provide a SNI with icons exported into
a temporary path. Hence the lack of support breaks icons for all Qt apps
on Ubuntu.

Fix:
- in the dataengine export IconThemePath
- in the systray protocol pick up the value and forward to QML
- in QML set the themePath accordingly on the IconItem
  (requires changes in runtime)

https://bugs.launchpad.net/ubuntu/+source/kde-workspace/+bug/1088772
BUG: 311555
CCMAIL: 1088772 at bugs.launchpad.net
REVIEW: 107702


This addresses bug 311555.
    http://bugs.kde.org/show_bug.cgi?id=311555


Diffs (updated)
-----

  plasma/generic/applets/systemtray/package/contents/ui/StatusNotifierItem.qml d286c2d727b53febb704d01371974fcfcc0dd10f 
  plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.h 127b301fee5357f4080e0ca9fc867df8af746146 
  plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.cpp 63642727630d721fa10151507004eba516715507 
  plasma/generic/dataengines/statusnotifieritem/statusnotifieritemsource.cpp 61d85f83e250eb3922a7d8a9efad106725fbca99 

Diff: http://git.reviewboard.kde.org/r/107702/diff/


Testing
-------

regular KSNI: works (juk, kmix, klipper..)
QSTI providing SNI via sni-qt: works (mumble)
QSTI using xembed: works (mumble)


Thanks,

Harald Sitter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121217/1b60a261/attachment.html>