Review Request: KSNI: fix IconThemePath support

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107703/#review23409
-----------------------------------------------------------


is a quite big regression so something has definitely to be done yeah...
looking at this part i'm a bit hesitant about exposing themepath in this component, because it would be needed pretty much just there.
luckily the systray has a c++ part, so
another option would be creating the custom iconloader in the c++ part of the systray, then set the icon as a QIcon in the iconitem.
opinions?

- Marco Martin


On Dec. 13, 2012, 2:19 p.m., Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107703/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2012, 2:19 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Also see https://git.reviewboard.kde.org/r/107702/
> 
> 
> KSNI: fix IconThemePath support
> 
> IconThemePath is used by a Canonical Patch to enable all Qt apps using
> QSystemTrayIcon to transparently provide a SNI with icons exported into
> a temporary path. Hence the lack of support breaks icons for all Qt apps
> on Ubuntu.
> 
> Fix:
> - IconItem has a new property themePath which will update a custom icon
>   loader
> - Use the iconloader to get a KIcon when necessary
> - Trigger icon updates when either the source (name/data...) or the theme
>   path changes
> 
> https://bugs.launchpad.net/ubuntu/+source/kde-workspace/+bug/1088772
> BUG: 311555
> CCMAIL: 1088772 at bugs.launchpad.net
> 
> 
> This addresses bug 311555.
>     http://bugs.kde.org/show_bug.cgi?id=311555
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/core/iconitem.h 16513b0622e8f3910db11642be85794a9bf0418e 
>   plasma/declarativeimports/core/iconitem.cpp 765e7eddac53fc4a6e3a1704ffff581b240e4c72 
> 
> Diff: http://git.reviewboard.kde.org/r/107703/diff/
> 
> 
> Testing
> -------
> 
> regular KSNI: works (juk, kmix, klipper..)
> QSTI providing SNI via sni-qt: works (mumble)
> QSTI using xembed: works (mumble)
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121213/b7738c61/attachment.html>