Review Request: show notification summary for last popup notification

[Xuetian Weng]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107743/
-----------------------------------------------------------

(Updated Dec. 17, 2012, 2:18 a.m.)


Review request for Plasma and Marco Martin.


Changes
-------

Further postion fix.. set to window type to tooltip is kinds of mess, PlasmaCore.Dialog test Tooltip to change the edge hug behavior. Borrow some positon setting code from systemtray ArrowArea.qml, update position upon size change. Which seems also fix wrong/ugly edge hug layout problem. Use align center because the click popup seems to be center aligned too.


Description
-------

New qml notification doesn't show summary for last popup notification. This patch add summary back.


This addresses bug 307670.
    http://bugs.kde.org/show_bug.cgi?id=307670


Diffs (updated)
-----

  plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml e63526b 
  plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml 9e4345a 

Diff: http://git.reviewboard.kde.org/r/107743/diff/


Testing
-------

No problem here. Looks ok.


Screenshots
-----------

current appearance
  http://git.reviewboard.kde.org/r/107743/s/899/


Thanks,

Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121217/467ee38b/attachment.html>