Review Request: show notification summary for last popup notification

[Xuetian Weng]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107743/
-----------------------------------------------------------

(Updated Dec. 16, 2012, 11:17 p.m.)


Review request for Plasma and Marco Martin.


Changes
-------

I think I found why it's not bold.. PlasmaComponenets.Label is a QML Text, and weight is already bind with default.themeFont.weight, and bold is just kinds of alias to set Bold. so it's not working. This update fixes them all. Now bold work, and it will not take space if summary is empty.


Description
-------

New qml notification doesn't show summary for last popup notification. This patch add summary back.


This addresses bug 307670.
    http://bugs.kde.org/show_bug.cgi?id=307670


Diffs (updated)
-----

  plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml e63526b 
  plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml 9e4345a 

Diff: http://git.reviewboard.kde.org/r/107743/diff/


Testing
-------

No problem here. Looks ok.


Screenshots
-----------

current appearance
  http://git.reviewboard.kde.org/r/107743/s/899/


Thanks,

Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121216/073c2008/attachment.html>