Review Request: Pager QML port

[Shaun Reich]

> On Aug. 21, 2012, 5:15 p.m., Marco Martin wrote:
> > found a small issue: when there is only one desktop, the pager should show nothing and be only few pixels wide (effectively "hidden")
> 
> Marco Martin wrote:
>     what's the status on this? can it be merged?
> 
> Luis Gabriel Lima wrote:
>     I'll upload a new diff soon (today or tomorrow) with a bug fixed and the hidden feature.
> 
> Luis Gabriel Lima wrote:
>     I was looking the pager history and I found this commit: http://quickgit.kde.org/index.php?p=kde-workspace.git&a=commit&h=9bee3f3fbf3f4b91caf04ede5bfe1d1aec41f66e
>     Should we really bring this hidden behavior back?
> 
> Marco Martin wrote:
>     when semi invisible it should still have some width and react to right clicks, but that revert wasn't good

the revert was needed because it was entirely invisible ;-)
iow you couldn't click it or anything, it just took up blank space iirc. not opposed to being -somewhat- hidden in that mode, as long as it doesn't turn into "where'd the pager go? what's this gap doing here for?"


- Shaun


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106112/#review17812
-----------------------------------------------------------


On Aug. 30, 2012, 2:30 a.m., Luis Gabriel Lima wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106112/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2012, 2:30 a.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> This patch contains the QML port of the Pager plasmoid done during the GSoC 2012.
> 
> In this port basically I used QML to paint the Pager UI and deal with the user interaction. 
> The geometry calculation of the desktop and window rectangles was kept in C++ as well as other routines that needs to interact with classes like KWindowSystem, QDbusConnection and so on.
> This patch also introduces the PagerModel, a QAIM subclass that holds the desktop/window geometries and is used by the QML part to fill the UI.
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/pager/CMakeLists.txt 5d80514 
>   plasma/desktop/applets/pager/model.h PRE-CREATION 
>   plasma/desktop/applets/pager/model.cpp PRE-CREATION 
>   plasma/desktop/applets/pager/package/contents/ui/main.qml PRE-CREATION 
>   plasma/desktop/applets/pager/package/contents/ui/utils.js PRE-CREATION 
>   plasma/desktop/applets/pager/package/metadata.desktop PRE-CREATION 
>   plasma/desktop/applets/pager/pager.h 6c7c045 
>   plasma/desktop/applets/pager/pager.cpp 74dc529 
> 
> Diff: http://git.reviewboard.kde.org/r/106112/diff/
> 
> 
> Testing
> -------
> 
> - Tested inside panels and floating on desktop, sizing works as expected
> - Mouse interactions (move windows around, change desktop, etc)
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/106112/s/691/
> 
>   http://git.reviewboard.kde.org/r/106112/s/692/
> 
> 
> Thanks,
> 
> Luis Gabriel Lima
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120831/03c58cb5/attachment-0001.html>