Review Request: Pager QML port

[Luis Gabriel Lima]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106112/
-----------------------------------------------------------

(Updated Aug. 30, 2012, 2:30 a.m.)


Review request for Plasma and Marco Martin.


Changes
-------

- Fixed a crash when removing desktops
- When there is only one desktop the pager is hidden


Description
-------

This patch contains the QML port of the Pager plasmoid done during the GSoC 2012.

In this port basically I used QML to paint the Pager UI and deal with the user interaction. 
The geometry calculation of the desktop and window rectangles was kept in C++ as well as other routines that needs to interact with classes like KWindowSystem, QDbusConnection and so on.
This patch also introduces the PagerModel, a QAIM subclass that holds the desktop/window geometries and is used by the QML part to fill the UI.


Diffs (updated)
-----

  plasma/desktop/applets/pager/CMakeLists.txt 5d80514 
  plasma/desktop/applets/pager/model.h PRE-CREATION 
  plasma/desktop/applets/pager/model.cpp PRE-CREATION 
  plasma/desktop/applets/pager/package/contents/ui/main.qml PRE-CREATION 
  plasma/desktop/applets/pager/package/contents/ui/utils.js PRE-CREATION 
  plasma/desktop/applets/pager/package/metadata.desktop PRE-CREATION 
  plasma/desktop/applets/pager/pager.h 6c7c045 
  plasma/desktop/applets/pager/pager.cpp 74dc529 

Diff: http://git.reviewboard.kde.org/r/106112/diff/


Testing
-------

- Tested inside panels and floating on desktop, sizing works as expected
- Mouse interactions (move windows around, change desktop, etc)


Screenshots
-----------


  http://git.reviewboard.kde.org/r/106112/s/691/

  http://git.reviewboard.kde.org/r/106112/s/692/


Thanks,

Luis Gabriel Lima

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120830/439a9d9a/attachment.html>