Review Request: Fixes for PlasmaCore.SortFilterModel
Aurélien Gâteau
agateau at kde.org
Tue Aug 28 15:56:56 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106248/
-----------------------------------------------------------
Review request for Plasma and Marco Martin.
Description
-------
This patch fixes a few tiny problems with PlasmaCore.SortFilterModel:
- it adds notify signals to filterRegExp and model properties
- it allows setting source model of SortFilterModel to 0
Diffs
-----
plasma/declarativeimports/core/tests/CMakeLists.txt PRE-CREATION
plasma/declarativeimports/core/tests/sortfiltermodeltest.h PRE-CREATION
plasma/declarativeimports/core/tests/sortfiltermodeltest.cpp PRE-CREATION
plasma/declarativeimports/core/CMakeLists.txt 49f2914
plasma/declarativeimports/core/datamodel.h cf82648
plasma/declarativeimports/core/datamodel.cpp 00108b1
Diff: http://git.reviewboard.kde.org/r/106248/diff/
Testing
-------
Patch comes with unittests for the changes. I also tested it with KDE Homerun (we have a copy of the class in the code because it needs to work with KDE 4.8 for now).
Thanks,
Aurélien Gâteau
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120828/b41a2888/attachment.html>
More information about the Plasma-devel
mailing list