<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106248/">http://git.reviewboard.kde.org/r/106248/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Aurélien Gâteau.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch fixes a few tiny problems with PlasmaCore.SortFilterModel:
- it adds notify signals to filterRegExp and model properties
- it allows setting source model of SortFilterModel to 0</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Patch comes with unittests for the changes. I also tested it with KDE Homerun (we have a copy of the class in the code because it needs to work with KDE 4.8 for now).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/declarativeimports/core/tests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/declarativeimports/core/tests/sortfiltermodeltest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/declarativeimports/core/tests/sortfiltermodeltest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/declarativeimports/core/CMakeLists.txt <span style="color: grey">(49f2914)</span></li>
<li>plasma/declarativeimports/core/datamodel.h <span style="color: grey">(cf82648)</span></li>
<li>plasma/declarativeimports/core/datamodel.cpp <span style="color: grey">(00108b1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106248/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>