Review Request: rtm: Add rtm.pro for use when building librtm with qmake in QTONLY mode.

[Jeremy Paul Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105734/
-----------------------------------------------------------

(Updated Aug. 18, 2012, 3:15 a.m.)


Review request for Plasma and Andrew Stromme.


Changes
-------

A few more commits to fix some items found when using rtm in Remember for Harmattan.


Description
-------

If this last set of changes is ok with you guys I'd like to merge this back to master branch and start looking at fixing some of the TODO items etc on master.  At this point it's ready for me to start using in QTONLY build on harmattan.  

rtm: Add rtm.pro for use when building librtm with qmake in QTONLY mode.


rtm: Add QTONLY #ifndefs around kde specific code.


rtm: Change #include of moc files to use qmake file naming scheme.


rtm: Change request to use QNetworkAccessManager.


rtm: Move RequestPrivate into a private header. rtm: Change protected slots to Q_PRIVATE_SLOT.


Change kDebug to qDebug.


plasma_applet_rtm: Add KWebView for login to configuration dialog. Update rtm authservice to do two step login:  Step 1: request login url.  Step 2: continue after user has logged in and authorized.


rtm: Remove KWebView from rtm library. Emit signals for login url so application/applet can display webview.


rtm: Move Request private data into RequestPrivate class in .cpp file. rtm: Move Auth private data into AuthPrivate class in .cpp file. rtm: Clean up auth.h and request.h files.


rtm: Clean up rtm header files.


Add #include <rtm/task.h> since we use Task * (and session.h has been cleaned up).


Diffs (updated)
-----

  applets/rememberthemilk/CMakeLists.txt 18424ead610b78710fa896a4ea3986fcd7e2f364 
  applets/rememberthemilk/authenticate.ui cf7b9330d6d8f834225878f24eeb9be90651dbef 
  applets/rememberthemilk/rememberthemilk-plasmoid.h cf02fbad4ab3e46d051d26b2de55c2ff01fb00b8 
  applets/rememberthemilk/rememberthemilk-plasmoid.cpp 3413e59c69c079480efb2ba37e63927ad45df56e 
  dataengines/rememberthemilk/authservice.h 31f44284422ea4ffdcc7631b5b321a1785480cdb 
  dataengines/rememberthemilk/authservice.cpp c75e6cb6414920871358982aa226b3cbab1ca02f 
  dataengines/rememberthemilk/rtmauth.operations 155a8ae6bdfde4d4fa1056ba0cc750ea6b9214e1 
  dataengines/rememberthemilk/taskservice.cpp d738093ffd7c5183cf24f9f932d0c7f934b6634b 
  libs/rtm/CMakeLists.txt 58ab4939812bbce07068a6da8c1a1194f6377595 
  libs/rtm/auth.h 5f693fa53fc273e2a3782ac57e8c1ca3f8b194a1 
  libs/rtm/auth.cpp 16fd5f0c28004dcc12140556e8d6727c483c2ed9 
  libs/rtm/list.h c0c9c1a7619786093eabba379c328cca4b885147 
  libs/rtm/list.cpp 0d233e9776d8a9088f63f5f8bc11b9ef3ad94602 
  libs/rtm/note.h af4cfd20c6ddaf1a4943f76f148c79918b5ec633 
  libs/rtm/request.h d371714c144bf9bc6c7304a861840334f0846cdb 
  libs/rtm/request.cpp 1304cb5d1a547d08b7f82e44cd319097991c8425 
  libs/rtm/request_p.h PRE-CREATION 
  libs/rtm/rtm.h 1a542f6007c63df13b79dd60da0cfcfe294f8e16 
  libs/rtm/rtm.pro PRE-CREATION 
  libs/rtm/rtm_export.h c0873ed8e4e9542718daf28356570d16752e70b8 
  libs/rtm/session.h aad145c44c70fb28fe1496b93d991667e918f630 
  libs/rtm/session.cpp 051838f58c8f7a6b6aea9511f1d455197fafb08b 
  libs/rtm/session_p.h 8ffedcf0cb92c65a58ee4c5786611ca8d4895eb5 
  libs/rtm/task.cpp 938aa2d6cc9f08372816151a3bb5177156282886 
  libs/rtm/tests/login.cpp 03c2f3b0a4757cdb83a961f2e3c18a8b96212e8c 
  libs/rtm/tests/refresh.cpp 71178ce58052f843fb64ab2bfe0c1e7c79a96d81 
  libs/rtm/xmlreaders.h b9ea78ca567e32aceb70361a2735b7b005d15777 
  libs/rtm/xmlreaders.cpp 8b358abbe0810210c18b1f61528f441ec7f39914 

Diff: http://git.reviewboard.kde.org/r/105734/diff/


Testing
-------

It builds and runs ok here (the rtm applet logs in and loads data ok).


Thanks,

Jeremy Paul Whiting

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120818/6801e688/attachment-0001.html>