<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105734/">http://git.reviewboard.kde.org/r/105734/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Andrew Stromme.</div>
<div>By Jeremy Paul Whiting.</div>
<p style="color: grey;"><i>Updated Aug. 18, 2012, 3:15 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A few more commits to fix some items found when using rtm in Remember for Harmattan.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If this last set of changes is ok with you guys I'd like to merge this back to master branch and start looking at fixing some of the TODO items etc on master. At this point it's ready for me to start using in QTONLY build on harmattan.
rtm: Add rtm.pro for use when building librtm with qmake in QTONLY mode.
rtm: Add QTONLY #ifndefs around kde specific code.
rtm: Change #include of moc files to use qmake file naming scheme.
rtm: Change request to use QNetworkAccessManager.
rtm: Move RequestPrivate into a private header. rtm: Change protected slots to Q_PRIVATE_SLOT.
Change kDebug to qDebug.
plasma_applet_rtm: Add KWebView for login to configuration dialog. Update rtm authservice to do two step login: Step 1: request login url. Step 2: continue after user has logged in and authorized.
rtm: Remove KWebView from rtm library. Emit signals for login url so application/applet can display webview.
rtm: Move Request private data into RequestPrivate class in .cpp file. rtm: Move Auth private data into AuthPrivate class in .cpp file. rtm: Clean up auth.h and request.h files.
rtm: Clean up rtm header files.
Add #include <rtm/task.h> since we use Task * (and session.h has been cleaned up).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It builds and runs ok here (the rtm applet logs in and loads data ok).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/rememberthemilk/CMakeLists.txt <span style="color: grey">(18424ead610b78710fa896a4ea3986fcd7e2f364)</span></li>
<li>applets/rememberthemilk/authenticate.ui <span style="color: grey">(cf7b9330d6d8f834225878f24eeb9be90651dbef)</span></li>
<li>applets/rememberthemilk/rememberthemilk-plasmoid.h <span style="color: grey">(cf02fbad4ab3e46d051d26b2de55c2ff01fb00b8)</span></li>
<li>applets/rememberthemilk/rememberthemilk-plasmoid.cpp <span style="color: grey">(3413e59c69c079480efb2ba37e63927ad45df56e)</span></li>
<li>dataengines/rememberthemilk/authservice.h <span style="color: grey">(31f44284422ea4ffdcc7631b5b321a1785480cdb)</span></li>
<li>dataengines/rememberthemilk/authservice.cpp <span style="color: grey">(c75e6cb6414920871358982aa226b3cbab1ca02f)</span></li>
<li>dataengines/rememberthemilk/rtmauth.operations <span style="color: grey">(155a8ae6bdfde4d4fa1056ba0cc750ea6b9214e1)</span></li>
<li>dataengines/rememberthemilk/taskservice.cpp <span style="color: grey">(d738093ffd7c5183cf24f9f932d0c7f934b6634b)</span></li>
<li>libs/rtm/CMakeLists.txt <span style="color: grey">(58ab4939812bbce07068a6da8c1a1194f6377595)</span></li>
<li>libs/rtm/auth.h <span style="color: grey">(5f693fa53fc273e2a3782ac57e8c1ca3f8b194a1)</span></li>
<li>libs/rtm/auth.cpp <span style="color: grey">(16fd5f0c28004dcc12140556e8d6727c483c2ed9)</span></li>
<li>libs/rtm/list.h <span style="color: grey">(c0c9c1a7619786093eabba379c328cca4b885147)</span></li>
<li>libs/rtm/list.cpp <span style="color: grey">(0d233e9776d8a9088f63f5f8bc11b9ef3ad94602)</span></li>
<li>libs/rtm/note.h <span style="color: grey">(af4cfd20c6ddaf1a4943f76f148c79918b5ec633)</span></li>
<li>libs/rtm/request.h <span style="color: grey">(d371714c144bf9bc6c7304a861840334f0846cdb)</span></li>
<li>libs/rtm/request.cpp <span style="color: grey">(1304cb5d1a547d08b7f82e44cd319097991c8425)</span></li>
<li>libs/rtm/request_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rtm/rtm.h <span style="color: grey">(1a542f6007c63df13b79dd60da0cfcfe294f8e16)</span></li>
<li>libs/rtm/rtm.pro <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rtm/rtm_export.h <span style="color: grey">(c0873ed8e4e9542718daf28356570d16752e70b8)</span></li>
<li>libs/rtm/session.h <span style="color: grey">(aad145c44c70fb28fe1496b93d991667e918f630)</span></li>
<li>libs/rtm/session.cpp <span style="color: grey">(051838f58c8f7a6b6aea9511f1d455197fafb08b)</span></li>
<li>libs/rtm/session_p.h <span style="color: grey">(8ffedcf0cb92c65a58ee4c5786611ca8d4895eb5)</span></li>
<li>libs/rtm/task.cpp <span style="color: grey">(938aa2d6cc9f08372816151a3bb5177156282886)</span></li>
<li>libs/rtm/tests/login.cpp <span style="color: grey">(03c2f3b0a4757cdb83a961f2e3c18a8b96212e8c)</span></li>
<li>libs/rtm/tests/refresh.cpp <span style="color: grey">(71178ce58052f843fb64ab2bfe0c1e7c79a96d81)</span></li>
<li>libs/rtm/xmlreaders.h <span style="color: grey">(b9ea78ca567e32aceb70361a2735b7b005d15777)</span></li>
<li>libs/rtm/xmlreaders.cpp <span style="color: grey">(8b358abbe0810210c18b1f61528f441ec7f39914)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105734/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>