Review Request: Improve ProgressBar display

[Aleix Pol Gonzalez]

> On Aug. 15, 2012, 11:34 p.m., David Edmundson wrote:
> > plasma/declarativeimports/plasmacomponents/qml/ProgressBar.qml, line 139
> > <http://git.reviewboard.kde.org/r/105966/diff/3/?file=76993#file76993line139>
> >
> >     You've kept the trigger for width changing, but not height.
> >     
> >     That doesn't sound right.

You were correct, I've already fixed it.

It's not very important because the progressbar is rotated, but it's good to have it nevertheless. Thanks!


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105966/#review17495
-----------------------------------------------------------


On Aug. 10, 2012, 4:12 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105966/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2012, 4:12 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Fix sizing and look of the ProgressBar.
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/plasmacomponents/qml/ProgressBar.qml 67805ca 
> 
> Diff: http://git.reviewboard.kde.org/r/105966/diff/
> 
> 
> Testing
> -------
> 
> kde:scratch/apol/kdeqmlviewer + http://proli.net/meu/kde/testprogress.qml
> 
> 
> Screenshots
> -----------
> 
> before
>   http://git.reviewboard.kde.org/r/105966/s/669/
> after
>   http://git.reviewboard.kde.org/r/105966/s/671/
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120815/ae122cb9/attachment.html>