Review Request: Improve ProgressBar display
David Edmundson
kde at davidedmundson.co.uk
Wed Aug 15 23:34:32 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105966/#review17495
-----------------------------------------------------------
plasma/declarativeimports/plasmacomponents/qml/ProgressBar.qml
<http://git.reviewboard.kde.org/r/105966/#comment13690>
You've kept the trigger for width changing, but not height.
That doesn't sound right.
- David Edmundson
On Aug. 10, 2012, 4:12 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105966/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2012, 4:12 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Fix sizing and look of the ProgressBar.
>
>
> Diffs
> -----
>
> plasma/declarativeimports/plasmacomponents/qml/ProgressBar.qml 67805ca
>
> Diff: http://git.reviewboard.kde.org/r/105966/diff/
>
>
> Testing
> -------
>
> kde:scratch/apol/kdeqmlviewer + http://proli.net/meu/kde/testprogress.qml
>
>
> Screenshots
> -----------
>
> before
> http://git.reviewboard.kde.org/r/105966/s/669/
> after
> http://git.reviewboard.kde.org/r/105966/s/671/
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120815/d48d1820/attachment.html>
More information about the Plasma-devel
mailing list