Review Request: increase the width of the group items in the popup of the task manager applet

Commit Hook null at kde.org
Wed Aug 15 21:50:19 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105849/#review17491
-----------------------------------------------------------


This review has been submitted with commit 1e64a33e3d64e51de5fadd67cdbe036f7a605f2d by Martin Koller to branch master.

- Commit Hook


On Aug. 15, 2012, 7:06 p.m., Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105849/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2012, 7:06 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> this patch changes the width of the task group popup to be able to read the full title of the window.
> The minimum width is like it was before, but if the title is wider, it will increase the width up to 80% of the available
> corona width.
> 
> This patch is in line with the goals of the task applet. In the README I find:
> "The tasks applet should try to make it as easy as possible
> for the user to perform a 'context switch' between the different
> tasks they are performing."
> 
> Before my patch I could often not easily find which group item I have to click as I could not
> read the full title of the window.
> 
> 
> This addresses bug 302125.
>     http://bugs.kde.org/show_bug.cgi?id=302125
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/tasks/abstracttaskitem.cpp 835fb27 
>   plasma/desktop/applets/tasks/taskgroupitem.cpp d846a4c 
>   plasma/desktop/applets/tasks/taskitemlayout.cpp 079c18d 
> 
> Diff: http://git.reviewboard.kde.org/r/105849/diff/
> 
> 
> Testing
> -------
> 
> checked panel on all screen edges, ungrouped/grouped task items, added, removed group items (windows)
> with longer titles while/before opening the popup.
> 
> 
> Thanks,
> 
> Martin Koller
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120815/e1ec951b/attachment.html>


More information about the Plasma-devel mailing list