Review Request: fix calculation of notification timeout
Martin Koller
kollix at aon.at
Sat Aug 4 20:33:21 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105858/
-----------------------------------------------------------
Review request for Plasma and Aurélien Gâteau.
Description
-------
In checking the above bug, I found that the calculation of the timeout of a notification has a nice idea implemented, but it does not
work due to a bug.
The code should create longer timeouts for longer texts, but have at least 5 seconds.
Due to using 2000 + qMin(timeout, 3000), the result will be maximum 5 seconds. This patch changes this to qMax so that
we really get longer timeouts than 5 seconds.
This addresses bug 178411.
http://bugs.kde.org/show_bug.cgi?id=178411
Diffs
-----
plasma/generic/dataengines/notifications/notificationsengine.cpp caaca27
Diff: http://git.reviewboard.kde.org/r/105858/diff/
Testing
-------
notify-send with very long text and debugging output of timeout
Thanks,
Martin Koller
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120804/5274a125/attachment.html>
More information about the Plasma-devel
mailing list