Review Request: Mouse hover effect on ListItem

[Marco Martin]

> On Aug. 9, 2012, 3:17 p.m., Marco Martin wrote:
> > i think it makes sense, two important things should be assured tough:
> > a) on the normal case, with click disabled, the effect muct be disabled as well (it disables the mouse area so should work)
> > b) now a touch version without effect becomes necessary
> 
> Aleix Pol Gonzalez wrote:
>     a) If ListItem.enabled is false, then the mouse area will be disabled. So there will be not such effect.
>     b) why? the behavior should be the same, no?
> 
> Marco Martin wrote:
>     there isn't the concept of mouseover there, since you don't see the cursor and you can't move it without clicking ;)
> 
> Aleix Pol Gonzalez wrote:
>     I'm not sure if you're speaking from a theoretical point of view or I'm just a bit dumb...
>     
>     In any case, what do I do with the patch?

is not theoretical, for touch we have some components replaced with versions that behave differently (for instance scroll indicators in place of scrollbars, and no mouseover effect for things like buttons)

you can give them a try by exporting the env var KDE_PLASMA_COMPONENTS_PLATFORM=touch  (in general a good idea testing apps with both)

commit this as is for now, will add a simple config file in the components for now to enable/disable mouseover without duplicating the whole widget code


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105939/#review17158
-----------------------------------------------------------


On Aug. 9, 2012, 12:08 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105939/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2012, 12:08 a.m.)
> 
> 
> Review request for Plasma, Marco Martin and Daker Pinheiro.
> 
> 
> Description
> -------
> 
> Reduce opacity of the ListItem's background decoration when it's hovered and the item is enabled.
> It's interesting because it improves the GUI responsiveness when using a mouse.
> 
> Of course this 0.5 can be changed/discussed :)
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/plasmacomponents/qml/ListItem.qml 8511a26 
> 
> Diff: http://git.reviewboard.kde.org/r/105939/diff/
> 
> 
> Testing
> -------
> 
> played with muon discover a bit
> 
> 
> Screenshots
> -----------
> 
> a hovered item
>   http://git.reviewboard.kde.org/r/105939/s/668/
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120810/7356968c/attachment-0001.html>