<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105939/">http://git.reviewboard.kde.org/r/105939/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 9th, 2012, 3:17 p.m., <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i think it makes sense, two important things should be assured tough:
a) on the normal case, with click disabled, the effect muct be disabled as well (it disables the mouse area so should work)
b) now a touch version without effect becomes necessary</pre>
</blockquote>
<p>On August 9th, 2012, 3:23 p.m., <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">a) If ListItem.enabled is false, then the mouse area will be disabled. So there will be not such effect.
b) why? the behavior should be the same, no?</pre>
</blockquote>
<p>On August 9th, 2012, 3:28 p.m., <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">there isn't the concept of mouseover there, since you don't see the cursor and you can't move it without clicking ;)</pre>
</blockquote>
<p>On August 9th, 2012, 10:44 p.m., <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not sure if you're speaking from a theoretical point of view or I'm just a bit dumb...
In any case, what do I do with the patch?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">is not theoretical, for touch we have some components replaced with versions that behave differently (for instance scroll indicators in place of scrollbars, and no mouseover effect for things like buttons)
you can give them a try by exporting the env var KDE_PLASMA_COMPONENTS_PLATFORM=touch (in general a good idea testing apps with both)
commit this as is for now, will add a simple config file in the components for now to enable/disable mouseover without duplicating the whole widget code</pre>
<br />
<p>- Marco</p>
<br />
<p>On August 9th, 2012, 12:08 a.m., Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Marco Martin and Daker Pinheiro.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Aug. 9, 2012, 12:08 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Reduce opacity of the ListItem's background decoration when it's hovered and the item is enabled.
It's interesting because it improves the GUI responsiveness when using a mouse.
Of course this 0.5 can be changed/discussed :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">played with muon discover a bit</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/declarativeimports/plasmacomponents/qml/ListItem.qml <span style="color: grey">(8511a26)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105939/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/105939/s/668/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/09/muon-hover_400x100.png" style="border: 1px black solid;" alt="a hovered item" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>