Review Request: fix html tag handling in notification message

Martin Koller kollix at aon.at
Fri Aug 3 09:35:48 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105836/
-----------------------------------------------------------

Review request for Plasma and Marco Martin.


Description
-------

as described in the bug report, some combinations of html tags or < > brackets do not display correctly.
I found some bugs in the message preparation code which this patch fixes.


This addresses bug 302890.
    http://bugs.kde.org/show_bug.cgi?id=302890


Diffs
-----

  plasma/generic/applets/notifications/ui/notificationwidget.cpp 880f1e4 

Diff: http://git.reviewboard.kde.org/r/105836/diff/


Testing
-------

notify-send - 'b < a >'
notify-send - '<a>'
notify-send - 'a >'
notify-send - 'a > b'
notify-send - 'a>b'
notify-send - '<a>b'
notify-send - '>a>b'
notify-send - '> a > b'
notify-send - '< a < b'
notify-send - '< a < b'
notify-send - '> <'
notify-send - '>'
notify-send - '< a < b'
notify-send - '> a > b'
notify-send - 'a > a > b'
notify-send - 'a > '
notify-send - 'a > b'


Thanks,

Martin Koller

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120803/f0e63caf/attachment.html>


More information about the Plasma-devel mailing list