Review Request: Changed MediaItemDelegate.qml, more space between items, a frame for pictures, fixed keyboardinteraction.
Giorgos Tsiapaliwkas
terietor at gmail.com
Thu Aug 2 07:59:12 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105816/#review16784
-----------------------------------------------------------
browsingbackends/metadatabackends/metadatamusicbackend/nepomukmusicmodel.h
<http://git.reviewboard.kde.org/r/105816/#comment13073>
the indentation is wrong.
also we prefer this,
void error(const QString& msg);
instead of void error(QString);
- Giorgos Tsiapaliwkas
On Aug. 1, 2012, 3:02 p.m., Fabian Riethmayer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105816/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2012, 3:02 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Added slot error(QString) for nepomukmusicmodel. Changed MediaItemDelegate.qml, more space between items, a frame for pictures, fixed keyboardinteraction.
>
>
> Diffs
> -----
>
> browsingbackends/metadatabackends/metadatamusicbackend/nepomukmusicmodel.h 1ba77e7
> browsingbackends/metadatabackends/metadatamusicbackend/nepomukmusicmodel.cpp d4f7449
> components/mediabrowser/MediaItemDelegate.qml bd181ab
>
> Diff: http://git.reviewboard.kde.org/r/105816/diff/
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
> PMC Pictures
> http://git.reviewboard.kde.org/r/105816/s/660/
>
>
> Thanks,
>
> Fabian Riethmayer
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120802/c7021532/attachment-0001.html>
More information about the Plasma-devel
mailing list