<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105816/">http://git.reviewboard.kde.org/r/105816/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/105816/diff/1/?file=75598#file75598line44" style="color: black; font-weight: bold; text-decoration: underline;">browsingbackends/metadatabackends/metadatamusicbackend/nepomukmusicmodel.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">44</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="kt">void</span> <span class="n">error</span><span class="p">(</span><span class="n">QString</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the indentation is wrong.
also we prefer this,
void error(const QString& msg);
instead of void error(QString);</pre>
</div>
<br />
<p>- Giorgos</p>
<br />
<p>On August 1st, 2012, 3:02 p.m., Fabian Riethmayer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Fabian Riethmayer.</div>
<p style="color: grey;"><i>Updated Aug. 1, 2012, 3:02 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added slot error(QString) for nepomukmusicmodel. Changed MediaItemDelegate.qml, more space between items, a frame for pictures, fixed keyboardinteraction.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>browsingbackends/metadatabackends/metadatamusicbackend/nepomukmusicmodel.h <span style="color: grey">(1ba77e7)</span></li>
<li>browsingbackends/metadatabackends/metadatamusicbackend/nepomukmusicmodel.cpp <span style="color: grey">(d4f7449)</span></li>
<li>components/mediabrowser/MediaItemDelegate.qml <span style="color: grey">(bd181ab)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105816/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/105816/s/660/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/01/pmc-pictures_400x100.jpeg" style="border: 1px black solid;" alt="PMC Pictures" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>