Review Request: Icon applet - Recognition of desktop files without .desktop extension

Greg T yellowcake- at gmx.net
Fri Apr 27 18:14:50 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104764/
-----------------------------------------------------------

Review request for Plasma.


Description
-------

isDesktopFile() of KDesktopFile only looks at the file extension. This is not sufficient in a lot of cases, i.e. if you create a 'Link to Location' with dolphin it creates a desktop file without the .desktop extension. isDesktopFile check of KFileItem seems to working better and doesn't just look at the file suffix.


This addresses bug 266870.
    http://bugs.kde.org/show_bug.cgi?id=266870


Diffs
-----

  plasma/generic/applets/icon/icon.cpp 4bdbae4 

Diff: http://git.reviewboard.kde.org/r/104764/diff/


Testing
-------

bug fixed


Thanks,

Greg T

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120427/41eba64f/attachment.html>


More information about the Plasma-devel mailing list