Review Request: icon plasmoid - http url naming

Commit Hook null at kde.org
Fri Apr 20 20:21:58 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103435/#review12735
-----------------------------------------------------------


This review has been submitted with commit 246d9bcc81878977d68c3cc030f1b6fd2e28cb87 by Gregor Tätzner to branch KDE/4.8.

- Commit Hook


On Jan. 10, 2012, 1:41 p.m., Greg T wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103435/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2012, 1:41 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> I added a special case so the desktop icon gets a pretty name when you drag and drop a link onto your desktop. Additional, a regex strips out the protocol (like in firefox) 
> 
> I'm allowed to commit it?
> 
> 
> This addresses bug 199811.
>     http://bugs.kde.org/show_bug.cgi?id=199811
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/icon/icon.cpp b25e5d6 
> 
> Diff: http://git.reviewboard.kde.org/r/103435/diff/
> 
> 
> Testing
> -------
> 
> looks good
> 
> 
> Thanks,
> 
> Greg T
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120420/37fe4619/attachment.html>


More information about the Plasma-devel mailing list