Review Request: Plasmate:images can now be added to projects

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102290/#review6952
-----------------------------------------------------------



editors/imageviewer/imageviewer.h
<http://git.reviewboard.kde.org/r/102290/#comment6144>

    this should have your name and email address



editors/imageviewer/imageviewer.h
<http://git.reviewboard.kde.org/r/102290/#comment6142>

    this should probably be setImage and QString image() const, since it doesn't actually set a directory to view but a specific image.



editors/imageviewer/imageviewer.h
<http://git.reviewboard.kde.org/r/102290/#comment6143>

    these could be private, or even merged into setImage



editors/imageviewer/imageviewer.cpp
<http://git.reviewboard.kde.org/r/102290/#comment6145>

    this should have your name and email address instead



editors/imageviewer/imageviewer.cpp
<http://git.reviewboard.kde.org/r/102290/#comment6149>

    there is no layout (e.g. a QHBoxLayout) that the QLabel/QSvgWidget can be put into. this is why the image is showing up small and in the top corner.



editors/imageviewer/imageviewer.cpp
<http://git.reviewboard.kde.org/r/102290/#comment6141>

    after setting the path, the code that is currently in init() should be called. i'd recommend getting rid fo the init() method, in fact, and merging it with this one.



editors/imageviewer/imageviewer.cpp
<http://git.reviewboard.kde.org/r/102290/#comment6148>

    this is a memory leak if commonImages() is called more than once. it should be something like:
    
    if (!m_label) {
        m_label = new QLabel(this);
    }
    
    m_label->setPixmap(image);
    
    this also implies initializing the m_label pointer to 0 in the constructor



editors/imageviewer/imageviewer.cpp
<http://git.reviewboard.kde.org/r/102290/#comment6147>

    this should be new'd and added to the layout, otherwise the svg won't be visible, correct?



editors/imageviewer/imageviewer.cpp
<http://git.reviewboard.kde.org/r/102290/#comment6146>

    seems unnecessary 



mainwindow.cpp
<http://git.reviewboard.kde.org/r/102290/#comment6140>

    would it be better to do this as something like:
    
    if (!m_imageViewer) {
        m_imageViewer = new ImageViewer(this);
        m_imageViewer->init();
    }
    
    m_imageViewer->setDirectory(target);
    ... etc


- Aaron J. Seigo


On Sept. 28, 2011, 8:39 p.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102290/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2011, 8:39 p.m.)
> 
> 
> Review request for Plasma and Aaron J. Seigo.
> 
> 
> Description
> -------
> 
> hello,
> 
> without this patch a user cannot add an image with plasmate.
> 
> reproduce,go to files-images-new,the plasmate will open a text editor instead of a dialog,which(the dialog) is able to open an image.
> 
> With the patch a dialog will open asking for an image.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt f3f32a9 
>   editors/editpage.h 7b5dca3 
>   editors/editpage.cpp d4b0082 
>   editors/imageviewer/imageviewer.h PRE-CREATION 
>   editors/imageviewer/imageviewer.cpp PRE-CREATION 
>   mainwindow.h 1b1c2a2 
>   mainwindow.cpp 3199f03 
>   packagemodel.cpp 8c0907a 
> 
> Diff: http://git.reviewboard.kde.org/r/102290/diff/diff
> 
> 
> Testing
> -------
> 
> the patch is not ready yet,i have noted some questions.
> Also the plasmate tries to open the image with a text editor.This have to be fixed,but how?Should we make plasmate able to preview images?
> 
> In addition,when you add something in the list of files(using the different options provided by the files qdockwidget) it names it as "new".This has to be fixed and the plasmate has to show the real name of the file.(different request,i just want an approval for this patch).
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliwkas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20110930/b1edb9a8/attachment-0001.html>