Review Request: Plasmate:images can now be added to projects

[Giorgos Tsiapaliwkas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102290/
-----------------------------------------------------------

(Updated Sept. 28, 2011, 8:39 p.m.)


Review request for Plasma and Aaron J. Seigo.


Changes
-------

with the patch plasmate is now able to add images and also to print them on the screen..

The patch has two issues,
1)the license part
2)the small images appear in the top left corner when they should be appear in the center.

i need some help with those two.


Description
-------

hello,

without this patch a user cannot add an image with plasmate.

reproduce,go to files-images-new,the plasmate will open a text editor instead of a dialog,which(the dialog) is able to open an image.

With the patch a dialog will open asking for an image.


Diffs (updated)
-----

  CMakeLists.txt f3f32a9 
  editors/editpage.h 7b5dca3 
  editors/editpage.cpp d4b0082 
  editors/imageviewer/imageviewer.h PRE-CREATION 
  editors/imageviewer/imageviewer.cpp PRE-CREATION 
  mainwindow.h 1b1c2a2 
  mainwindow.cpp 3199f03 
  packagemodel.cpp 8c0907a 

Diff: http://git.reviewboard.kde.org/r/102290/diff/diff


Testing
-------

the patch is not ready yet,i have noted some questions.
Also the plasmate tries to open the image with a text editor.This have to be fixed,but how?Should we make plasmate able to preview images?

In addition,when you add something in the list of files(using the different options provided by the files qdockwidget) it names it as "new".This has to be fixed and the plasmate has to show the real name of the file.(different request,i just want an approval for this patch).


Thanks,

Giorgos Tsiapaliwkas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20110928/aa84fd66/attachment.html>