Review Request: quicklaunch: Add a confirmation dialog before the delete

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102727/#review6906
-----------------------------------------------------------


First, this is the wrong way to fix it. Why should this confirmation only go for a specific widget? This introduces inconsistence in the UI that leads to more data loss (the next time a user deletes a widget, she'll expect there to be a confirmation, and there won't).

Adding a modal dialog is a no-go as well, it blocks the UI and causes general nastiness.

The correct solution against data loss bugs is not to add confirmation dialogs, but to make the action less destructive, for example by adding a way to undo the delete.

- Sebastian Kügler


On Sept. 28, 2011, 8:44 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102727/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2011, 8:44 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Hello,
> 
> This patch is adding a new feature to the quicklaunch plasmaoid.
> 
> 
> This addresses bug 270105.
>     http://bugs.kde.org/show_bug.cgi?id=270105
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/quicklaunch/quicklaunch.cpp dfc6125 
> 
> Diff: http://git.reviewboard.kde.org/r/102727/diff/diff
> 
> 
> Testing
> -------
> 
> kde-workspace compiles fine.
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20110929/2ffda0ca/attachment.html>