Review Request: quicklaunch: Add a confirmation dialog before the delete

[Lukas Appelhans]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102727/#review6904
-----------------------------------------------------------


Hey!

Even though I'm not anymore the maintainer of the quicklaunch plasmoid I'm going to comment on this.

The patch looks fine to me, although I would probably show in the MessageBox which item gets removed. That way the user can easily recognize *before* removing the item if he clicked the wrong item or not.

Lukas

- Lukas Appelhans


On Sept. 28, 2011, 8:44 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102727/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2011, 8:44 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Hello,
> 
> This patch is adding a new feature to the quicklaunch plasmaoid.
> 
> 
> This addresses bug 270105.
>     http://bugs.kde.org/show_bug.cgi?id=270105
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/quicklaunch/quicklaunch.cpp dfc6125 
> 
> Diff: http://git.reviewboard.kde.org/r/102727/diff/diff
> 
> 
> Testing
> -------
> 
> kde-workspace compiles fine.
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20110929/5c3a9d53/attachment.html>