Review Request: Plasmate:add a destructor and some changes to the destructor of mainwindow.ccp
Aaron J. Seigo
aseigo at kde.org
Mon Sep 26 12:22:58 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101916/#review6828
-----------------------------------------------------------
mainwindow.cpp
<http://git.reviewboard.kde.org/r/101916/#comment6082>
unecessary change.
publisher/signingwidget.h
<http://git.reviewboard.kde.org/r/101916/#comment6083>
the standard signature for this is: QWidget *parent = 0
publisher/signingwidget.cpp
<http://git.reviewboard.kde.org/r/101916/#comment6084>
the parent needs to be passed into QWidget()
publisher/signingwidget.cpp
<http://git.reviewboard.kde.org/r/101916/#comment6085>
unneeded once the above is fixed
- Aaron J. Seigo
On Sept. 23, 2011, 4:20 p.m., Giorgos Tsiapaliwkas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101916/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2011, 4:20 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> hello,
>
> I was looking at the projectmanager.projectmanager.[h/cpp] and i noticed that there wasn't no destructor.
> The patch adds a destructor at projectmanager and changed a bit the mainwindow.cpp.
>
> I have some question in my next reply
>
>
> Diffs
> -----
>
> mainwindow.cpp 3199f03
> previewer/plasmoid/previewcontainment.cpp 7983cdf
> previewer/runner/runnerpreviewer.cpp 84c6268
> projectmanager/projectmanager.h a99b14f
> projectmanager/projectmanager.cpp c9c3797
> publisher/publisher.cpp 211b4e6
> publisher/signingwidget.h ce40d56
> publisher/signingwidget.cpp a4ff7a8
> savesystem/branchdialog.cpp c8a2482
> sidebar.cpp c9b9318
>
> Diff: http://git.reviewboard.kde.org/r/101916/diff/diff
>
>
> Testing
> -------
>
> compiles fine and no pointer error
>
>
> Thanks,
>
> Giorgos Tsiapaliwkas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20110926/52078af7/attachment.html>
More information about the Plasma-devel
mailing list