Review Request: Plasmate:add a destructor and some changes to the destructor of mainwindow.ccp

Giorgos Tsiapaliwkas terietor at gmail.com
Fri Sep 23 16:20:57 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101916/
-----------------------------------------------------------

(Updated Sept. 23, 2011, 4:20 p.m.)


Review request for Plasma.


Changes
-------

sorry for delay and for my absence but i had to study for my university exams..
This is the complete version of my patch in which i try to fix all the memory issues that i found


Summary
-------

hello,

I was looking at the projectmanager.projectmanager.[h/cpp] and i noticed that there wasn't no destructor.
The patch adds a destructor at projectmanager and changed a bit the mainwindow.cpp.

I have some question in my next reply


Diffs (updated)
-----

  mainwindow.cpp 3199f03 
  previewer/plasmoid/previewcontainment.cpp 7983cdf 
  previewer/runner/runnerpreviewer.cpp 84c6268 
  projectmanager/projectmanager.h a99b14f 
  projectmanager/projectmanager.cpp c9c3797 
  publisher/publisher.cpp 211b4e6 
  publisher/signingwidget.h ce40d56 
  publisher/signingwidget.cpp a4ff7a8 
  savesystem/branchdialog.cpp c8a2482 
  sidebar.cpp c9b9318 

Diff: http://git.reviewboard.kde.org/r/101916/diff


Testing
-------

compiles fine and no pointer error


Thanks,

Giorgos

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20110923/19194238/attachment.html>


More information about the Plasma-devel mailing list