Review Request: Plasmate: Metadata is now able to detect the correct api

[Antonis Tsiapaliokas]

> On Sept. 14, 2011, 10:53 a.m., Aaron J. Seigo wrote:
> > editors/metadata/metadata.ui, lines 312-314
> > <http://git.reviewboard.kde.org/r/102609/diff/1/?file=36114#file36114line312>
> >
> >     wonder how that snuck in...

my mystake. I guess that "LayoutDirectionAuto" is the correct option...


> On Sept. 14, 2011, 10:53 a.m., Aaron J. Seigo wrote:
> > editors/metadata/metadataeditor.cpp, lines 185-187
> > <http://git.reviewboard.kde.org/r/102609/diff/1/?file=36116#file36116line185>
> >
> >     cd("..") only works if the project was created by plasmate. if it was imported from an existing location, the rc file is in the same directory. unfortunate, but how it is. look for other instances of cd("..") to see how this is worked around elsewhere.

I have a better idea. Instead of finding the correct api into the metadataeditor, we can find it on startpage. Because like that if the api is broken, and someone is using the api in another place of plasmate, then his patch  will only work if he opens the metadataeditor. Do you think that  this is a good idea?


- Antonis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102609/#review6497
-----------------------------------------------------------


On Sept. 14, 2011, 8:31 a.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102609/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2011, 8:31 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Hello
> 
> In the toolbar files, there is a menu with name metadata, which is responsible to retrieve/write some information to the metadata.desktop file. Write now the plasmate cannot detect the correct api. This  patch is fixing  this issue.
> 
> 
> Diffs
> -----
> 
>   editors/metadata/metadata.ui 454643e 
>   editors/metadata/metadataeditor.h f0ae30c 
>   editors/metadata/metadataeditor.cpp 2b9f89c 
>   startpage.h 5a4a5c8 
>   startpage.cpp 4fe287b 
> 
> Diff: http://git.reviewboard.kde.org/r/102609/diff
> 
> 
> Testing
> -------
> 
> Plasmate compiles fines.
> The only thing that has been left, is to add "the correct" QLabel to metadata menu.
> 
> 
> Thanks,
> 
> Antonis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20110915/56fad27b/attachment-0001.html>