Review Request: Plasmate: Metadata is now able to detect the correct api

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102609/#review6497
-----------------------------------------------------------


great start, nearly there! some additional work is needed imho on what gets stored in which configuration file, but that's all very simple details on top of what you've already done.


editors/metadata/metadata.ui
<http://git.reviewboard.kde.org/r/102609/#comment5748>

    wonder how that snuck in...



editors/metadata/metadataeditor.cpp
<http://git.reviewboard.kde.org/r/102609/#comment5749>

    cd("..") only works if the project was created by plasmate. if it was imported from an existing location, the rc file is in the same directory. unfortunate, but how it is. look for other instances of cd("..") to see how this is worked around elsewhere.



editors/metadata/metadataeditor.cpp
<http://git.reviewboard.kde.org/r/102609/#comment5750>

    shoujld probably just be called "Project" or similar in the per-project rc file as it isn't about new projects at all :)



startpage.cpp
<http://git.reviewboard.kde.org/r/102609/#comment5751>

    easier would be to just store the new project settings in plasmaterc as usual. then we don't have to worry about a coupling between how recentProjects is handled and new project defaults.



startpage.cpp
<http://git.reviewboard.kde.org/r/102609/#comment5747>

    this should be saved in both places, so that when the user goes back to create a new project again, the settings they used last are there again (without having to rely on the implementation / ordering of recentProjects()).
    
    in the per-project rc file, the group name should probably just be called "Project" (or similar) in the per-project rc file as it isn't about new projects at all :) .. things like the email address, username, etc. also don't need to be stored here as they are already in the project's metadata.desktop file.


- Aaron J.


On Sept. 14, 2011, 8:31 a.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102609/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2011, 8:31 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Hello
> 
> In the toolbar files, there is a menu with name metadata, which is responsible to retrieve/write some information to the metadata.desktop file. Write now the plasmate cannot detect the correct api. This  patch is fixing  this issue.
> 
> 
> Diffs
> -----
> 
>   editors/metadata/metadata.ui 454643e 
>   editors/metadata/metadataeditor.h f0ae30c 
>   editors/metadata/metadataeditor.cpp 2b9f89c 
>   startpage.h 5a4a5c8 
>   startpage.cpp 4fe287b 
> 
> Diff: http://git.reviewboard.kde.org/r/102609/diff
> 
> 
> Testing
> -------
> 
> Plasmate compiles fines.
> The only thing that has been left, is to add "the correct" QLabel to metadata menu.
> 
> 
> Thanks,
> 
> Antonis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20110914/6042e02d/attachment-0001.html>