Review Request: Plasmate: Metadata is now able to detect the correct api
Antonis Tsiapaliokas
kok3rs at gmail.com
Fri Oct 21 19:30:44 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102609/
-----------------------------------------------------------
(Updated Oct. 21, 2011, 7:30 p.m.)
Review request for Plasma.
Changes
-------
Hello
I have update my patch. Now the .plasmateprojectrc and the metadata.desktop are checked if they have the correct api. And if not then the plasmate is trying to find the correct one using the .plasmateprojectrc or metadata.desktop, based on which of those has the problem. If both of them are broken, then the user is selecting the correct one from the metadata editor.
Description
-------
Hello
In the toolbar files, there is a menu with name metadata, which is responsible to retrieve/write some information to the metadata.desktop file. Write now the plasmate cannot detect the correct api. This patch is fixing this issue.
Diffs (updated)
-----
editors/metadata/metadata.ui 454643e
editors/metadata/metadataeditor.h f0ae30c
editors/metadata/metadataeditor.cpp 2b9f89c
mainwindow.h 1b1c2a2
mainwindow.cpp 2fa2742
startpage.h 5a4a5c8
startpage.cpp fc00441
Diff: http://git.reviewboard.kde.org/r/102609/diff/diff
Testing
-------
Plasmate compiles fines.
The only thing that has been left, is to add "the correct" QLabel to metadata menu.
Thanks,
Antonis Tsiapaliokas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111021/18aa5f80/attachment-0001.html>
More information about the Plasma-devel
mailing list