Review Request: Plasmate: Metadata is now able to detect the correct api

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102609/#review7104
-----------------------------------------------------------

Ship it!


Ship It!

- Aaron J. Seigo


On Sept. 24, 2011, 12:28 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102609/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2011, 12:28 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Hello
> 
> In the toolbar files, there is a menu with name metadata, which is responsible to retrieve/write some information to the metadata.desktop file. Write now the plasmate cannot detect the correct api. This  patch is fixing  this issue.
> 
> 
> Diffs
> -----
> 
>   editors/metadata/metadata.ui 454643e 
>   editors/metadata/metadataeditor.h f0ae30c 
>   editors/metadata/metadataeditor.cpp 2b9f89c 
>   mainwindow.h 1b1c2a2 
>   mainwindow.cpp 3199f03 
>   startpage.h 5a4a5c8 
>   startpage.cpp 859d346 
> 
> Diff: http://git.reviewboard.kde.org/r/102609/diff/diff
> 
> 
> Testing
> -------
> 
> Plasmate compiles fines.
> The only thing that has been left, is to add "the correct" QLabel to metadata menu.
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111005/5ccdf8fa/attachment.html>