Review Request: Fix wrong nameDisplayOrder in classic menu (simpleapplet)

[Luc Menut]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102820/
-----------------------------------------------------------

Review request for Plasma, Aaron J. Seigo and Marco Martin.


Description
-------

In simpleapplet, since the svn commit r1142273 (https://projects.kde.org/projects/kde/kde-workspace/repository/revisions/dd2e280819fab83807fa431d279768cc10b88742), Favorites, Recently Used and Recently Used Applications don't follow the user's choice for the format, and display the applications with the reverse order; if the user chooses "Name only" or "Name Description", they display with description before the name, and vice versa. Only the Application menu is displayed correctly with the correct order.
r1142273 was committed to fix a regression (BUG:241736) after r1046898 (add an exception for the "Games" category and always show it as title first - https://projects.kde.org/projects/kde/kde-workspace/repository/revisions/a4174ab2af1c0cc75b7ad8d6452599d7cca52d4b ).

The proposed patch fixes the bug 249501, and moreover allows to always display Games with title first in simpleapplet, like in kickoff (purpose of r1046898); the display order between name and description isn't anymore made by MenuView::updateAction, but MenuLauncherApplet::showMenu uses the models to do so (setNameDisplayOrder(Kickoff::NameBeforeDescription) for format "name" or "name description").


regards,
Luc Menut
Mageia Contributor


PS: I don't have write access to kde git, so could you commit the change for me if the patch looks fine. Thanks.


This addresses bug 249501.
    http://bugs.kde.org/show_bug.cgi?id=249501


Diffs
-----

  plasma/desktop/applets/kickoff/simpleapplet/menuview.cpp fce0fab 
  plasma/desktop/applets/kickoff/simpleapplet/simpleapplet.cpp 9e0448e 

Diff: http://git.reviewboard.kde.org/r/102820/diff/diff


Testing
-------

tested with KDE 4.7.2 (Mageia Cauldron)


Thanks,

Luc Menut

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111010/e63e4062/attachment-0001.html>