<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102820/">http://git.reviewboard.kde.org/r/102820/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Aaron J. Seigo and Marco Martin.</div>
<div>By Luc Menut.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In simpleapplet, since the svn commit r1142273 (https://projects.kde.org/projects/kde/kde-workspace/repository/revisions/dd2e280819fab83807fa431d279768cc10b88742), Favorites, Recently Used and Recently Used Applications don't follow the user's choice for the format, and display the applications with the reverse order; if the user chooses "Name only" or "Name Description", they display with description before the name, and vice versa. Only the Application menu is displayed correctly with the correct order.
r1142273 was committed to fix a regression (BUG:241736) after r1046898 (add an exception for the "Games" category and always show it as title first - https://projects.kde.org/projects/kde/kde-workspace/repository/revisions/a4174ab2af1c0cc75b7ad8d6452599d7cca52d4b ).
The proposed patch fixes the bug 249501, and moreover allows to always display Games with title first in simpleapplet, like in kickoff (purpose of r1046898); the display order between name and description isn't anymore made by MenuView::updateAction, but MenuLauncherApplet::showMenu uses the models to do so (setNameDisplayOrder(Kickoff::NameBeforeDescription) for format "name" or "name description").
regards,
Luc Menut
Mageia Contributor
PS: I don't have write access to kde git, so could you commit the change for me if the patch looks fine. Thanks.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">tested with KDE 4.7.2 (Mageia Cauldron)</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=249501">249501</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/applets/kickoff/simpleapplet/menuview.cpp <span style="color: grey">(fce0fab)</span></li>
<li>plasma/desktop/applets/kickoff/simpleapplet/simpleapplet.cpp <span style="color: grey">(9e0448e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102820/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>