removing dependencies from kactivitymanagerd

Aaron J. Seigo aseigo at kde.org
Wed Oct 5 09:29:55 UTC 2011


On Tuesday, October 4, 2011 18:29:33 Ivan Cukic wrote:
> General question - do you want to create a fw5 branch or something like
> that?
> 
> Aaron
> 
> > KUniqueApplication: this lives in kdeui ... just to provide a way to
> > have only one instance of the app. ugh. in Frameworks there is libkdbus
> > which has a KDBusService which provides the same capabilities. porting
> > to that proved quite simple and straightforward and let ActivityManager
> > become a QCoreApplication subclass.
> 
> Do we even need KDBusService? Just a check of
> QDBusConnectionInterface::isServiceRegistered can be used for this.

yes, we could use that .. it's what KDBusService essentially does. however, 
that tends to, ime, lead to unnecessarily fragile code as classes like 
KDBusService usually end up accumulating odd bug fixes and work-arounds for 
edge cases.

it's one line of code to use KDBusService, and more than that to use 
isServiceRegistered directly. the downside of KDBusService is under Frameworks 
we'll pull in one more library .. though a very small one with no deps.

i really recommend KDBusService.

> > Well for Wayland we need to change KWindowSystem anyway and I don't
> > want to low level protocols. So who wants to
> 
> Is that going to be kwin-only, or we have a hope it will be picked up by
> others?

i'd prefer something not over dbus tied to one window manager if at all 
possible.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111005/2e8a53b1/attachment.sig>


More information about the Plasma-devel mailing list