Review Request: Plasmate: Add mimetype support into the "executable scripts"

Antonis Tsiapaliokas kok3rs at gmail.com
Mon Nov 28 09:29:54 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102357/
-----------------------------------------------------------

(Updated Nov. 28, 2011, 9:29 a.m.)


Review request for Plasma.


Changes
-------

Typo fixed. Also with my previous  patch if you could try to add a new file to the plasmoid with an extension, for example main.py and the plasmoid had api="Ruby" then the name of the file was main.py.rb.


Description
-------

Hello

If you open the "files" toolbar and you try to add something new with the "New.." in the executable scripts, then if you don't add the .{qml,js,rb,py}, then the file will be saved without the mimetype extension. This patch is fixing this issue.If you don't like something into the names which i gave, then let me know :)


Diffs (updated)
-----

  editors/editpage.h 7b5dca3 
  editors/editpage.cpp d4b0082 
  editors/metadata/metadataeditor.h e02d8e3 
  editors/metadata/metadataeditor.cpp 256e334 
  packagemodel.h a14033c 
  packagemodel.cpp 8c0907a 

Diff: http://git.reviewboard.kde.org/r/102357/diff/diff


Testing
-------

plasmate compiles fine. New files can be added into the other menus, without any issue. 


Thanks,

Antonis Tsiapaliokas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111128/2d79daac/attachment.html>


More information about the Plasma-devel mailing list