Review Request: Plasmate: Add mimetype support into the "executable scripts"

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102357/#review8560
-----------------------------------------------------------

Ship it!


minor issue left, but it's essentially ready to go ... cheers :)


packagemodel.h
<http://git.reviewboard.kde.org/r/102357/#comment7256>

    all the other enumeration values start with a capital letter. the on you added doesn't. :) 


- Aaron J. Seigo


On Nov. 28, 2011, 8:53 a.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102357/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2011, 8:53 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Hello
> 
> If you open the "files" toolbar and you try to add something new with the "New.." in the executable scripts, then if you don't add the .{qml,js,rb,py}, then the file will be saved without the mimetype extension. This patch is fixing this issue.If you don't like something into the names which i gave, then let me know :)
> 
> 
> Diffs
> -----
> 
>   editors/editpage.h 7b5dca3 
>   editors/editpage.cpp d4b0082 
>   editors/metadata/metadataeditor.h e02d8e3 
>   editors/metadata/metadataeditor.cpp 256e334 
>   packagemodel.h a14033c 
>   packagemodel.cpp 8c0907a 
> 
> Diff: http://git.reviewboard.kde.org/r/102357/diff/diff
> 
> 
> Testing
> -------
> 
> plasmate compiles fine. New files can be added into the other menus, without any issue. 
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111128/5b37ff24/attachment.html>