Review Request: Plasmate: Add mimetype support into the "executable scripts"

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102357/#review8474
-----------------------------------------------------------


a few minor issues (mostly formatting; we try and keep the code consistent as much as possible) but also a couple of actual (though still minor) adjustments: using the Package instead of manually using KUrl and cd; clearer method naming.


editors/editpage.h
<http://git.reviewboard.kde.org/r/102357/#comment7192>

    indented too far.



editors/editpage.cpp
<http://git.reviewboard.kde.org/r/102357/#comment7193>

    use kDebug for debug... it has nice features like being able to turn it off, log to files, etc. consisten with the rest of the code as welel.



editors/editpage.cpp
<http://git.reviewboard.kde.org/r/102357/#comment7195>

    whitespace: if (



editors/editpage.cpp
<http://git.reviewboard.kde.org/r/102357/#comment7196>

    this really should be asking the package for the root path and then appending metadata.desktop to that.



editors/editpage.cpp
<http://git.reviewboard.kde.org/r/102357/#comment7194>

    indentation



editors/editpage.cpp
<http://git.reviewboard.kde.org/r/102357/#comment7200>

    block is indented too far.



editors/metadata/metadataeditor.cpp
<http://git.reviewboard.kde.org/r/102357/#comment7198>

    should be "metadataIsValid" .. there is no editor here :)



editors/metadata/metadataeditor.cpp
<http://git.reviewboard.kde.org/r/102357/#comment7197>

    simply "return metadata->isValid();" would suffice?



editors/metadata/metadataeditor.cpp
<http://git.reviewboard.kde.org/r/102357/#comment7199>

    whitspace: if (


- Aaron J. Seigo


On Nov. 25, 2011, 12:10 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102357/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2011, 12:10 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Hello
> 
> If you open the "files" toolbar and you try to add something new with the "New.." in the executable scripts, then if you don't add the .{qml,js,rb,py}, then the file will be saved without the mimetype extension. This patch is fixing this issue.If you don't like something into the names which i gave, then let me know :)
> 
> 
> Diffs
> -----
> 
>   editors/editpage.h 7b5dca3 
>   editors/editpage.cpp d4b0082 
>   editors/metadata/metadataeditor.h e02d8e3 
>   editors/metadata/metadataeditor.cpp 256e334 
> 
> Diff: http://git.reviewboard.kde.org/r/102357/diff/diff
> 
> 
> Testing
> -------
> 
> plasmate compiles fine. New files can be added into the other menus, without any issue. 
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111126/b940a315/attachment-0001.html>