Review Request: Plasmate: Add mimetype support into the "executable scripts"

Antonis Tsiapaliokas kok3rs at gmail.com
Fri Nov 25 12:10:15 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102357/
-----------------------------------------------------------

(Updated Nov. 25, 2011, 12:10 p.m.)


Review request for Plasma.


Changes
-------

The differences between this patch and the old one, is that now editpage is useing the metadata editor, to find which is the default api of our plasmoid. Also some changes have happen to metadata editor. Those changes are making the metadata editor's api more flexible...


Description
-------

Hello

If you open the "files" toolbar and you try to add something new with the "New.." in the executable scripts, then if you don't add the .{qml,js,rb,py}, then the file will be saved without the mimetype extension. This patch is fixing this issue.If you don't like something into the names which i gave, then let me know :)


Diffs (updated)
-----

  editors/editpage.h 7b5dca3 
  editors/editpage.cpp d4b0082 
  editors/metadata/metadataeditor.h e02d8e3 
  editors/metadata/metadataeditor.cpp 256e334 

Diff: http://git.reviewboard.kde.org/r/102357/diff/diff


Testing
-------

plasmate compiles fine. New files can be added into the other menus, without any issue. 


Thanks,

Antonis Tsiapaliokas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111125/4f0e9cd7/attachment.html>


More information about the Plasma-devel mailing list